ChangeSet 1.797.149.3, 2002/12/04 01:02:55-08:00, rlievin@free.fr [PATCH] USB: tiglusb update - a patch against 2.5.50 (clean-up and includes Randy Dunlap's patch). diff -Nru a/drivers/usb/misc/tiglusb.c b/drivers/usb/misc/tiglusb.c --- a/drivers/usb/misc/tiglusb.c Thu Dec 5 15:27:32 2002 +++ b/drivers/usb/misc/tiglusb.c Thu Dec 5 15:27:32 2002 @@ -15,16 +15,11 @@ * for more info. * * History : - * 16/07/2002 : v1.04 -- Julien BLACHE - * + removed useless usblp_cleanup() - * + removed {un,}lock_kernel() as suggested on lkml - * + inlined clear_pipes() (used once) - * + inlined clear_device() (small, used twice) - * + removed tiglusb_find_struct() (used once, simple code) - * + replaced down() with down_interruptible() wherever possible - * + fixed double unregistering wrt devfs, causing devfs - * to force an oops when the device is deconnected - * + removed unused fields from struct tiglusb_t + * 1.0x, Romain & Julien: initial submit. + * 1.03, Greg Kroah: modifications. + * 1.04, Julien: clean-up & fixes; Romain: 2.4 backport. + * 1.05, Randy Dunlap: bug fix with the timeout parameter (divide-by-zero). + * 1.06, Romain: synched with 2.5, version/firmware changed (confusing). */ #include @@ -44,7 +39,7 @@ /* * Version Information */ -#define DRIVER_VERSION "1.04" +#define DRIVER_VERSION "1.06" #define DRIVER_AUTHOR "Romain Lievin & Julien Blache " #define DRIVER_DESC "TI-GRAPH LINK USB (aka SilverLink) driver" #define DRIVER_LICENSE "GPL" @@ -387,7 +382,7 @@ &tiglusb_fops, NULL); /* Display firmware version */ - info ("link cable version %i.%02x", + info ("firmware revision %i.%02x", dev->descriptor.bcdDevice >> 8, dev->descriptor.bcdDevice & 0xff); @@ -453,7 +448,7 @@ if (ints[0] > 0) { timeout = ints[1]; } - if (!timeout) + if (timeout <= 0) timeout = TIMAXTIME; return 1; @@ -494,9 +489,9 @@ return -1; } - info (DRIVER_DESC ", " DRIVER_VERSION); + info (DRIVER_DESC ", version " DRIVER_VERSION); - if (!timeout) + if (timeout <= 0) timeout = TIMAXTIME; return 0;