From johnpol@2ka.mipt.ru Mon Sep 12 07:54:37 2005 Date: Mon, 12 Sep 2005 17:12:43 +0400 From: Evgeniy Polyakov To: Greg KH Cc: Greg KH , Marcel Holtmann , Linus Torvalds , Andrew Morton , Subject: crc16: remove w1 specific comments. Message-ID: <20050912131242.GA19896@2ka.mipt.ru> Remove w1 comments from crc16.h and move specific constants into w1_ds2433.c where they are used. Replace %d with %zd. Signed-off-by: Evgeniy Polyakov Signed-off-by: Greg Kroah-Hartman --- drivers/w1/w1_ds2433.c | 6 +++++- include/linux/crc16.h | 16 +--------------- 2 files changed, 6 insertions(+), 16 deletions(-) --- gregkh-2.6.orig/drivers/w1/w1_ds2433.c 2005-09-12 10:47:37.000000000 -0700 +++ gregkh-2.6/drivers/w1/w1_ds2433.c 2005-09-12 12:30:56.000000000 -0700 @@ -15,6 +15,10 @@ #include #ifdef CONFIG_W1_F23_CRC #include + +#define CRC16_INIT 0 +#define CRC16_VALID 0xb001 + #endif #include "w1.h" @@ -214,7 +218,7 @@ static ssize_t w1_f23_write_bin(struct k #ifdef CONFIG_W1_F23_CRC /* can only write full blocks in cached mode */ if ((off & W1_PAGE_MASK) || (count & W1_PAGE_MASK)) { - dev_err(&sl->dev, "invalid offset/count off=%d cnt=%d\n", + dev_err(&sl->dev, "invalid offset/count off=%d cnt=%zd\n", (int)off, count); return -EINVAL; } --- gregkh-2.6.orig/include/linux/crc16.h 2005-09-12 10:47:44.000000000 -0700 +++ gregkh-2.6/include/linux/crc16.h 2005-09-12 12:30:56.000000000 -0700 @@ -1,22 +1,11 @@ /* * crc16.h - CRC-16 routine * - * Implements the standard CRC-16, as used with 1-wire devices: + * Implements the standard CRC-16: * Width 16 * Poly 0x8005 (x^16 + x^15 + x^2 + 1) * Init 0 * - * For 1-wire devices, the CRC is stored inverted, LSB-first - * - * Example buffer with the CRC attached: - * 31 32 33 34 35 36 37 38 39 C2 44 - * - * The CRC over a buffer with the CRC attached is 0xB001. - * So, if (crc16(0, buf, size) == 0xB001) then the buffer is valid. - * - * Refer to "Application Note 937: Book of iButton Standards" for details. - * http://www.maxim-ic.com/appnotes.cfm/appnote_number/937 - * * Copyright (c) 2005 Ben Gardner * * This source code is licensed under the GNU General Public License, @@ -28,9 +17,6 @@ #include -#define CRC16_INIT 0 -#define CRC16_VALID 0xb001 - extern u16 const crc16_table[256]; extern u16 crc16(u16 crc, const u8 *buffer, size_t len);